Deprecate SQTagUtil #1214
Merged
Deprecate SQTagUtil #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1214 +/- ##
===============================================
+ Coverage 68.702% 68.708% +0.006%
Complexity 8061 8061
===============================================
Files 542 542
Lines 32711 32711
Branches 5533 5533
===============================================
+ Hits 22473 22475 +2
+ Misses 8038 8036 -2
Partials 2200 2200
|
lbergelson
approved these changes
Nov 2, 2018
There was a problem hiding this comment.
@magicDGS I reworded your comment a little bit. Good catch!
| @@ -27,7 +27,9 @@ | |||
| * Utility methods for encoding and decoding the SQ tag value of SAMRecord. | |||
| * | |||
| * @author [email protected] | |||
| * @deprecated since 11/2018. SQ is a reserved tag that shouldn't be used and this code untested. | |||
There was a problem hiding this comment.
Suggested change
| * @deprecated since 11/2018. SQ is a reserved tag that shouldn't be used and this code untested. | |
| * @deprecated since 11/2018. SQ is a deprecated tag that should no longer be used. This code is untested and and unsupported. There is no replacement for these utilities. |
lbergelson
added
the
Waiting for revisions
|
I'm going to merge this as is because I want it to go in at the same time as the other samtag deprecations. |
|
Sorry for not answering - I had too much problems last months and I could not focus on this. Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #949
Checklist